Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More verbose messages when failing to load render engine #236

Merged
merged 1 commit into from
Feb 11, 2021
Merged

More verbose messages when failing to load render engine #236

merged 1 commit into from
Feb 11, 2021

Conversation

chapulina
Copy link
Contributor

@chapulina chapulina commented Feb 6, 2021 •
edited
Loading

I'm working on this as part of gazebosim/gz-sensors#18, but the current state of this PR applies even outside that context.

Summary

This is making error messages more verbose when loading a render engine:

  • If no render engine interface was found, but other interfaces were, print the names of the other interfaces.
  • If multiple render engines were found, warn the user that there were others, and keep choosing a random one (note that pluginNames is an unordered_set, so getting begin is "random").

Test it

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example world and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review
    another open pull request
    to support the maintainers

Note to maintainers: Remember to use Squash-Merge

@github-actions github-actions bot added the 🏢 edifice Ignition Edifice label Feb 6, 2021
@codecov
Copy link

codecov bot commented Feb 6, 2021 •
edited
Loading

Codecov Report

Merging #236 (9c5ba35) into ign-rendering3 (36bc282) will decrease coverage by 0.03%.
The diff coverage is 33.33%.

Impacted file tree graph

@@                Coverage Diff                 @@
##           ign-rendering3     #236      +/-   ##
==================================================
- Coverage           50.63%   50.59%   -0.04%     
==================================================
  Files                 129      129              
  Lines               11864    11877      +13     
==================================================
+ Hits                 6007     6009       +2     
- Misses               5857     5868      +11
Impacted Files Coverage Δ
src/RenderEngineManager.cc 74.20% <33.33%> (-3.68%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 36bc282...9c5ba35. Read the comment docs.

@ahcorde
Copy link
Contributor

ahcorde commented Feb 8, 2021

can we retarget this to a lower ign-rendering version instead of main ?

@chapulina
Copy link
Contributor Author

can we retarget this to a lower ign-rendering version instead of main ?

Yeah I can do that 👍 I'll just get ign-sensors working with ign-plugin first to see if I need more changes here before retargeting.

@chapulina
More verbose messages when failing to load render engine
9c5ba35 
Signed-off-by: Louise Poubel <louise@openrobotics.org>
@chapulina chapulina changed the base branch from main to ign-rendering3 February 11, 2021 01:06
@chapulina chapulina marked this pull request as ready for review February 11, 2021 01:10
@chapulina chapulina added 🏰 citadel Ignition Citadel and removed 🏢 edifice Ignition Edifice labels Feb 11, 2021
@chapulina
Copy link
Contributor Author

Retargeted to ign-rendering3 and opened for review.

@chapulina chapulina merged commit 51d0130 into ign-rendering3 Feb 11, 2021
@chapulina chapulina deleted the chapulina/5/plugin_loading branch February 11, 2021 18:40
@chapulina chapulina mentioned this pull request Mar 19, 2021
Closed
@chapulina chapulina mentioned this pull request May 7, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahcorde ahcorde ahcorde approved these changes

@iche033 iche033 Awaiting requested review from iche033 iche033 is a code owner

Assignees
No one assigned
Labels
🏰 citadel Ignition Citadel
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chapulina @ahcorde